Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: debug assert reservation states in process_success #3966

Merged
merged 11 commits into from
Aug 1, 2024
Merged

chore: debug assert reservation states in process_success #3966

merged 11 commits into from
Aug 1, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented May 16, 2024

@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label May 16, 2024
@playX18 playX18 self-assigned this May 16, 2024
breathx
breathx requested changes May 16, 2024
View reviewed changes
core-processor/src/processing.rs Outdated Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels May 16, 2024
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label May 17, 2024
@playX18 playX18 requested a review from breathx May 17, 2024 06:29
@playX18 playX18 requested review from techraed and breathx May 20, 2024 15:05
breathx
breathx requested changes May 26, 2024
View reviewed changes
core-processor/src/processing.rs Outdated Show resolved Hide resolved
@breathx breathx removed the A0-pleasereview PR is ready to be reviewed by the team label May 26, 2024
@breathx
Copy link
Member

breathx commented Jun 11, 2024

@playX18 why is it staling?

@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Jul 9, 2024
@playX18 playX18 requested a review from breathx July 10, 2024 09:37
@breathx
Copy link
Member

breathx commented Jul 10, 2024

@ark0f please take a look

@breathx breathx requested a review from ark0f July 10, 2024 14:18
@breathx breathx removed the A3-gotissues PR occurred to have issues after the review label Jul 10, 2024
techraed
techraed requested changes Jul 10, 2024
View reviewed changes
core-processor/src/processing.rs Outdated Show resolved Hide resolved
core-processor/src/processing.rs Outdated Show resolved Hide resolved
@playX18 playX18 requested a review from techraed July 11, 2024 11:06
techraed
techraed approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ark0f re-check, please

core-processor/src/processing.rs Outdated Show resolved Hide resolved
@playX18 @techraed
Remove comment
f3e4088 
Co-authored-by: Sabaun Taraki <[email protected]>
@playX18 playX18 requested a review from ark0f July 24, 2024 05:53
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 30, 2024
@playX18 playX18 merged commit ae2e775 into master Aug 1, 2024
10 checks passed
@playX18 playX18 deleted the ap/debug-assert branch August 1, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed approved these changes

@breathx breathx breathx approved these changes

@ark0f ark0f ark0f approved these changes

Assignees

@playX18 playX18

Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@playX18 @breathx @ark0f @techraed