Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update substrate to v0.9.42 #3186

Closed
wants to merge 18 commits into from
Closed

Conversation

ukint-vs
Copy link
Member

@ukint-vs ukint-vs commented Aug 26, 2023

todo:

  • update weights
  • fix balances weights

@gear-tech/dev

@ukint-vs ukint-vs added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D2-node Gear Node labels Aug 26, 2023
@ukint-vs ukint-vs self-assigned this Aug 26, 2023
@ukint-vs
Copy link
Member Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Analysis

  • 🎯 Main theme: Updating substrate to v0.9.43 and related changes
  • 📌 Type of PR: Enhancement
  • Focused PR: True
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • General suggestions: The PR seems to be well-structured and focused on updating the substrate version and making necessary changes related to it. However, it would be beneficial to add relevant tests to ensure the changes don't break any existing functionality.

  • 🤖 Code feedback:

    • relevant file: node/service/src/lib.rs
      suggestion: It seems like the error handling for remote keystores has been removed. If remote keystores are not supported, it would be better to keep the error handling to avoid potential issues. [important]
      relevant line: - if config.keystore_remote.is_some() {

    • relevant file: utils/gear-replay-cli/src/util.rs
      suggestion: The TaskExecutor has been removed from the full_extensions function. If the TaskExecutor is not needed anymore, make sure to remove its import as well to keep the code clean. [medium]
      relevant line: - extensions.register(TaskExecutorExt::new(TaskExecutor::new()));

    • relevant file: gsdk/api-gen/src/main.rs
      suggestion: The heap_pages parameter has been added to the WasmExecutor builder. It would be better to add a comment explaining why this parameter is needed and how the value of 1024 was chosen. [medium]
      relevant line: let heap_pages =

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@ukint-vs ukint-vs changed the title feat: Update substrate to v0.9.43 feat: Update substrate to v0.9.42 Aug 31, 2023
@breathx
Copy link
Member

breathx commented Sep 24, 2023

Temporary closing as stale and unstable

@breathx breathx closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants