Implement smart linking, take 2 #782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daid
force-pushed
the
smartlinking
branch
2 times, most recently
from
cb7ef26 to
488d4e2
Compare
Long-broken feature, fell into disrepair, got removed... Now it's back! Though, it needs testing. Fixes gbdev#82
Actually add the section to the smart link queue. Fix various smart linking issues Smart link after the linking script. Keep fully constrained sections with smart linking. Fix modifing the section hash map while you are iterating over it Remove the ffpad from the smart linking tests, it does not add anything while making the test script more complex and failing on Mac Fix some smart linking tests and remove some obviously broken/wrong ones. Add smart linking test to check if chained references are kept Remove -x link flag, as we cannot test everything we want with that Add a test to check if constrained sections are kept Add wram smart linking test, which will fail.
Rangi42
added
enhancement
4 tasks
|
Superseded by #1382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82, replaces and based on #654, including rebase and fixes.