Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to pass extra parameters to ros_gz_bridge (backport #628) #648

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

🎉 New feature

Closes #624

Summary

Added a new argument bridge_params to allow users to pass extra parameters to ros_gz_bridge when using the launch file. An example of these parameters would be qos_overrides
I have changed the node declarations to an opaque function so that I can get the value of bridge_params.
bridge_params is converted from string to dictionary and then passed to the parameters of the ros_gz_bridge node.
The way I have done all of this is complicated and so please do tell me if there is an easier way to do this.

Test it

To test this something like the following command can be used:
ros2 launch ros_gz_bridge ros_gz_bridge.launch.py bridge_name:=ros_gz_bridge config_file:=<path_to_your_YAML_file> bridge_params:="'qos_overrides./topic_name.publisher.durability': 'transient_local', 'qos_overrides./another_topic_name.publisher.durability': 'transient_local'"

Then to check if the qos overrides have applied:
ros2 topic info /topic_name --verbose
ros2 topic info /another_topic_name --verbose

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #628 done by Mergify.

* Add bridge_params argument to ros_gz_bridge
Signed-off-by: Aarav Gupta <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Wiktor Bajor <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Wiktor Bajor <[email protected]>
(cherry picked from commit 558a1cf)
@mergify mergify bot requested a review from ahcorde as a code owner November 21, 2024 12:27
@ahcorde ahcorde merged commit 22ba635 into jazzy Nov 21, 2024
6 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-628 branch November 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants