Use optional parameters in actions #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #554
Summary
This patch lets you use
<ros_gz_bridge>
and<gz_server>
XML elements without having to declare all its arguments.Testing the bridge
You can modify
ros_gz_bridge/launch/ros_gz_bridge.launch
with the following content (change your config_file path accordingly):Launch a ROS container:
Launch the bridge:
Verify that the component is loaded:
Verify that the
/ros_chatter
topic is listed:Testing
ros_gz_sim
Modify
ros_gz_sim/launch/ros_gz_sim.launch
with (change your config_file path accordingly):Launch
gzserver
and the bridge:Verify that the two components are loaded:
Verify that you see the logging messages from
gzserver
on the terminal and that the/ros_chatter
topic is listed:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.