Delete copy ctor and copy-assignment for log::Batch #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rule-of-five violation and reduces flakiness of playback tests. Signed-off-by: Michael Beardsworth <[email protected]>
ahcorde
reviewed
May 14, 2024
Looks like the error is on the previous commit f043ddb already on main? |
mjcarroll
approved these changes
May 16, 2024
azeey
approved these changes
May 20, 2024
|
It looks like the "Validate package.xml" Action fails because the base branch of this PR was changed and that workflow hasn't been forward ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fixes rule-of-five violation and reduces flakiness of playback tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.