Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ogre2 symbol visibility macro #972

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 28, 2024

🦟 Bug fix

Updated to use GZ_RENDERING_OGRE2_HIDDEN as opposed to DETAIL_GZ_RENDERING_OGRE2_HIDDEN.

We actually could just remove the use of these macros in cc files as they may not be necessary, especially in ionic when symbols are hidden by default.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.59%. Comparing base (b07e79d) to head (b46c97f).

Additional details and impacted files
@@                Coverage Diff                @@
##           gz-rendering8     #972      +/-   ##
=================================================
- Coverage          75.59%   75.59%   -0.01%     
=================================================
  Files                177      177              
  Lines              16934    16934              
=================================================
- Hits               12802    12801       -1     
- Misses              4132     4133       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 4f01a66 into gz-rendering8 Feb 29, 2024
8 of 10 checks passed
@iche033 iche033 deleted the ogre2_hidden_symbol branch February 29, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants