Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build fortress + jammy #1017

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 22, 2024

🦟 Bug fix

Summary

I was attempting to build Fortress on Jammy, and rand into:

 GraphicsAPI.hh:31:10: warning: elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword

followed by:

GraphicsAPI.hh:31:55: error: found ‘:’ in nested-name-specifier, expected ‘::’
   31 |     enum class IGNITION_RENDERING_VISIBLE GraphicsAPI : uint16_t

The fix was to include the header file where uint16_t is defined.

I'm using gcc 13.2.0.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from iche033 as a code owner July 22, 2024 12:51
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 22, 2024
@ahcorde ahcorde enabled auto-merge (squash) July 22, 2024 13:22
@iche033 iche033 disabled auto-merge July 22, 2024 20:20
@iche033 iche033 merged commit 95e66c7 into ign-rendering6 Jul 22, 2024
9 of 11 checks passed
@iche033 iche033 deleted the nkoenig/fix-build-fortress-jammy branch July 22, 2024 20:20
Crola1702 pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
iche033 pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants