Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gz-cmake declaration on package.xml (fix windows CI) #1005

Merged
merged 1 commit into from
May 22, 2024

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented May 22, 2024

🦟 Bug fix

Fix #1004

Summary

The build dependency is broken declaring gz-cmake instead of gz-cmake3. This is probably making colcon to ignore the gz-cmake3 install directory thus there is not gz-cmake3 config file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@j-rivero j-rivero requested a review from iche033 as a code owner May 22, 2024 14:50
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 22, 2024
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I'm not sure why CI passed in the PR(#981) that added this though.

@azeey azeey enabled auto-merge (squash) May 22, 2024 15:43
@j-rivero
Copy link
Contributor Author

Thanks for the fix! I'm not sure why CI passed in the PR(#981) that added this though.

weird indeed.

@j-rivero
Copy link
Contributor Author

can not merge it myself de to the lack of permissions and the failing tests 😢

@azeey azeey disabled auto-merge May 22, 2024 16:57
@azeey
Copy link
Contributor

azeey commented May 22, 2024

The failure seems unrelated, so I'll go ahead and merge to unblock other PRs.

@azeey azeey merged commit 9436d7b into gz-rendering8 May 22, 2024
9 of 11 checks passed
@azeey azeey deleted the jrivero/fix_cmake3_packagexml branch May 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

👩‍🌾 Error finding gz-cmake3 package build regression
3 participants