Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR 260 #302

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Backport PR 260 #302

merged 1 commit into from
Oct 28, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 27, 2021

Backport #260

Note to maintainers: Remember to use Rebase and merge

@azeey azeey requested review from mxgrey and scpeters as code owners October 27, 2021 22:41
@azeey azeey changed the base branch from ign-physics4 to ign-physics2 October 27, 2021 22:41
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 27, 2021
@azeey azeey added 🏰 citadel Ignition Citadel and removed 🏢 edifice Ignition Edifice labels Oct 27, 2021
@azeey azeey changed the title Backport 260 Backport PR 260 Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #302 (c4ac2fc) into ign-physics2 (1fd83e0) will decrease coverage by 0.39%.
The diff coverage is 63.52%.

❗ Current head c4ac2fc differs from pull request most recent head 3854170. Consider uploading reports for the commit 3854170 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2     #302      +/-   ##
================================================
- Coverage         83.23%   82.84%   -0.40%     
================================================
  Files               108      108              
  Lines              4158     4243      +85     
================================================
+ Hits               3461     3515      +54     
- Misses              697      728      +31     
Impacted Files Coverage Δ
dartsim/src/JointFeatures.cc 63.42% <49.18%> (-4.44%) ⬇️
include/ignition/physics/detail/Joint.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd83e0...3854170. Read the comment docs.

* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <[email protected]>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <[email protected]>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <[email protected]>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>

* Fixed issues from review.

Signed-off-by: Martin Pecka <[email protected]>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@azeey azeey merged commit ac44ede into gazebosim:ign-physics2 Oct 28, 2021
@azeey azeey deleted the backport_260 branch October 28, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants