Remove deprecations: tock #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
iche033
reviewed
Dec 4, 2024
| @@ -75,9 +75,6 @@ namespace gz | |||
| /// This has kept a bug for backwards compatibility, use | |||
| /// LOCAL2 for the correct behaviour. | |||
| LOCAL = 4, | |||
|
|
|||
| /// \brief Heading-adjusted tangent plane (X, Y, Z) | |||
| LOCAL2 = 5 | |||
There was a problem hiding this comment.
there's a GZ_UTILS_WARN_IGNORE__DEPRECATED_DECLARATION macro earlier in this file. Can that be removed?
There was a problem hiding this comment.
Thanks! I commented out it in the same way it is GZ_UTILS_WARN_RESUME__DEPRECATED_DECLARATION just in case it's useful in the future. d7997c4
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
ahcorde
approved these changes
Dec 4, 2024
iche033
approved these changes
Dec 4, 2024
peci1
approved these changes
Dec 5, 2024
Signed-off-by: Carlos Agüero <[email protected]>
Thanks for taking a look! Function removed in 1fb1410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Perform the tock of the tick-tock cycle and remove / move deprecated code.
@peci1
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.