Change to globbed bazel targets #652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ease of non-bazel maintainers lives Signed-off-by: Michael Carroll <[email protected]>
| hdrs = public_headers, | ||
| includes = [ | ||
| "include", | ||
| "src", |
There was a problem hiding this comment.
Do we need to add src to includes? I don't think any of the headers there should be publicly accessible?
| ":Conversions", | ||
| "@googletest//:gtest", | ||
| "@googletest//:gtest_main", | ||
| private_headers = glob( |
There was a problem hiding this comment.
Bazel 8 doesn't seem to like the empty glob:
ERROR: Traceback (most recent call last):
File "/home/runner/work/gz-math/gz-math/eigen3/BUILD.bazel", line 22, column 23, in
private_headers = glob(
Error in glob: glob pattern 'src/*.hh' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
ERROR: package contains errors: eigen3
Should we just remove the private_headers list from this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until I can test downstream impacts