Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-math6 ➡️ gz-math7 #582

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Merge ign-math6 ➡️ gz-math7 #582

merged 2 commits into from
Mar 14, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 14, 2024

➡️ Forward port

Port ign-math6 ➡️ gz-math7

Branch comparison: gz-math7...ign-math6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  ==================================== ERRORS ====================================
  ____ ERROR collecting src/python_pybind11/test/MecanumDriveOdometry_TEST.py ____
  ImportError while importing test module '/github/workspace/src/python_pybind11/test/MecanumDriveOdometry_TEST.py'.
  Hint: make sure your test modules/packages have valid Python names.
  Traceback:
  /usr/lib/python3.8/importlib/__init__.py:127: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  ../../../src/python_pybind11/test/MecanumDriveOdometry_TEST.py:20: in <module>
      from gz.math import MecanumDriveOdometry, Angle
  E   ModuleNotFoundError: No module named 'gz.math'
  - generated xml file: /github/workspace/build/test_results/MecanumDriveOdometry_TEST.xml -
  =========================== short test summary info ============================
  ERROR ../../../src/python_pybind11/test/MecanumDriveOdometry_TEST.py
  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
  =============================== 1 error in 0.10s ===============================

Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 94.11%. Comparing base (ec655a9) to head (48364a1).

Files Patch % Lines
src/python_pybind11/src/MecanumDriveOdometry.cc 75.86% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           gz-math7     #582      +/-   ##
============================================
- Coverage     94.16%   94.11%   -0.06%     
============================================
  Files           145      146       +1     
  Lines          9774     9804      +30     
============================================
+ Hits           9204     9227      +23     
- Misses          570      577       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit fe745ca into gazebosim:gz-math7 Mar 14, 2024
11 of 13 checks passed
@azeey azeey deleted the 6_to_7 branch March 14, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants