Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate config and log directories #188

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Migrate config and log directories #188

merged 1 commit into from
Aug 15, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from nkoenig as a code owner August 4, 2022 22:47
@methylDragon methylDragon changed the title ign -> gz Partial Docs and Project Name Followups : gz-launch ign -> gz Migrate config and log directories : gz-launch Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited
Loading

Codecov Report

Merging #188 (aec0805) into main (178645f) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

❗ Current head aec0805 differs from pull request most recent head fd1ed63. Consider uploading reports for the commit fd1ed63 to get more accurate results

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   56.90%   56.35%   -0.55%     
==========================================
  Files           3        3              
  Lines         413      417       +4     
==========================================
  Hits          235      235              
- Misses        178      182       +4
Impacted Files Coverage Δ
src/Manager.cc 53.09% <0.00%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@methylDragon methylDragon force-pushed the config_and_log_migration branch from 9ebb606 to 4f799f7 Compare August 4, 2022 23:00
@methylDragon methylDragon mentioned this pull request Aug 4, 2022
Open
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 4, 2022
chapulina
chapulina reviewed Aug 5, 2022
View reviewed changes
src/Manager.cc Outdated Show resolved Hide resolved
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 5, 2022
@methylDragon methylDragon force-pushed the config_and_log_migration branch from 30911f3 to d67da38 Compare August 11, 2022 17:53
@methylDragon methylDragon force-pushed the config_and_log_migration branch from d67da38 to fd1ed63 Compare August 11, 2022 18:00
@methylDragon methylDragon enabled auto-merge (squash) August 11, 2022 18:00
@methylDragon methylDragon disabled auto-merge August 11, 2022 18:55
@methylDragon methylDragon changed the title ign -> gz Migrate config and log directories : gz-launch Migrate config and log directories Aug 11, 2022
@chapulina chapulina merged commit 88e995a into main Aug 15, 2022
@chapulina chapulina deleted the config_and_log_migration branch August 15, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina