-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignitionrobotics to gazebosim #250
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me so far, I haven't tried running it though.
I didn't check if you left a test case using ignitionrobotics
to make sure it still works, but I think we should make sure that's tested.
conf/config.yaml
Outdated
# url: https://myserver | ||
- | ||
name: ignition | ||
url: https://fuel.ignition.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: https://fuel.ignition.org | |
url: https://fuel.ignitionrobotics.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/ignition.in
Outdated
@@ -768,7 +768,7 @@ WARN_FORMAT = "$file:$line: $text" | |||
# messages should be written. If left blank the output is written to standard | |||
# error (stderr). | |||
|
|||
WARN_LOGFILE = /tmp/ignition-fuel-tools.warn | |||
WARN_LOGFILE = /tmp/gazebo-fuel-tools.warn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARN_LOGFILE = /tmp/gazebo-fuel-tools.warn | |
WARN_LOGFILE = /tmp/gz-fuel-tools.warn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Nate Koenig <[email protected]>
Note to self, this world file results in many duplicate model downloads. It's probably because this PR is changing the server under the hood, but Gazebo is still trying to find the model using the
|
|
Summary
DRAFT I'm experimenting with changing the fuel servers.
This changes the default Fuel server from
fuel.ignitionrobotics.org
tofuel.gazebosim.org
.Additionally, requests to the
fuel.ignitionrobotics.org
server are changed tofuel.gazebosim.org
. This is needed in order to support models that have dependencies, which are all using thefuel.ignitionrobotics.org
server name. This should be okay sincefuel.ignitionrobotics.org
andfuel.gazebosim.org
are the same. The downside is that users transitioning from Ignition to Gazebo will have two folders:~/.ignition/fuel/fuel.ignitionrobotics.org
~/.ignition/fuel/fuel.gazebosim.org
.Note that I'm not changing the
~/.ignition
base directory since that seemed like too major of a change for a released version of fuel tools.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.