Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignitionrobotics to gazebosim #250

Closed
wants to merge 4 commits into from

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 4, 2022

Summary

DRAFT I'm experimenting with changing the fuel servers.

This changes the default Fuel server from fuel.ignitionrobotics.org to fuel.gazebosim.org.

Additionally, requests to the fuel.ignitionrobotics.org server are changed to fuel.gazebosim.org. This is needed in order to support models that have dependencies, which are all using the fuel.ignitionrobotics.org server name. This should be okay since fuel.ignitionrobotics.org and fuel.gazebosim.org are the same. The downside is that users transitioning from Ignition to Gazebo will have two folders:

  1. ~/.ignition/fuel/fuel.ignitionrobotics.org
  2. ~/.ignition/fuel/fuel.gazebosim.org.

Note that I'm not changing the ~/.ignition base directory since that seemed like too major of a change for a released version of fuel tools.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 2 commits May 4, 2022 09:08
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels May 4, 2022
@chapulina chapulina marked this pull request as draft May 5, 2022 17:45
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 5, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me so far, I haven't tried running it though.

I didn't check if you left a test case using ignitionrobotics to make sure it still works, but I think we should make sure that's tested.

conf/config.yaml Outdated
# url: https://myserver
-
name: ignition
url: https://fuel.ignition.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://fuel.ignition.org
url: https://fuel.ignitionrobotics.org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/ignition.in Outdated
@@ -768,7 +768,7 @@ WARN_FORMAT = "$file:$line: $text"
# messages should be written. If left blank the output is written to standard
# error (stderr).

WARN_LOGFILE = /tmp/ignition-fuel-tools.warn
WARN_LOGFILE = /tmp/gazebo-fuel-tools.warn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WARN_LOGFILE = /tmp/gazebo-fuel-tools.warn
WARN_LOGFILE = /tmp/gz-fuel-tools.warn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkoenig
Copy link
Contributor Author

nkoenig commented Jun 2, 2022

Note to self, this world file results in many duplicate model downloads. It's probably because this PR is changing the server under the hood, but Gazebo is still trying to find the model using the ignitionrobotics name. Need to look at this problem more.

<?xml version="1.0" ?>
<sdf version="1.6">
  <world name="shapes">
    <scene>
    <ambient>1.0 1.0 1.0</ambient>
    <background>0.8 0.8 0.8</background>
    </scene>

    <include>
      <uri>https://fuel.gazebosim.org/1.0/OpenRobotics/models/Tunnel Tile 4</uri>
    </include>
  </world>
</sdf>

@chapulina
Copy link
Contributor

@nkoenig nkoenig closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants