Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ign_find_package, ign_string_append, ign_build_error, ign_build_warning #258

Merged
merged 13 commits into from
May 24, 2022
Merged

Deprecate ign_find_package, ign_string_append, ign_build_error, ign_build_warning #258

merged 13 commits into from
May 24, 2022

Conversation

chapulina
Copy link
Contributor

Summary

#250 was getting too large. This PR migrates 4 functions.

Each commit migrates one or two functions.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 12 commits May 9, 2022 15:55
@chapulina
ign_manual_search
8b6c62c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_create_packages
2b95760 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_create_core_library
a074e5a 
Signed-off-by: Louise Poubel <[email protected]>
@scpeters
Merge branch 'main' into chapulina/3/ign_deprecations_3
7923d0e
@chapulina
Merge branch 'main' into chapulina/3/ign_deprecations_3
1a87c1a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina @methylDragon
Apply suggestions from code review
4df8477 
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>

Co-authored-by: methylDragon <[email protected]>
@chapulina
ign_configure_project, ign_check_os
0eaaacb 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_install_executable, ign_install_includes, ign_add_executable
1e4c7e4 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_import_target
78d2890 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_find_package
a9fdd74 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_string_append
de367f9 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
ign_build_error, ign_build_warning
596d260 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested review from mxgrey and j-rivero as code owners May 17, 2022 04:27
@chapulina chapulina requested a review from methylDragon May 17, 2022 04:28
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 17, 2022
@chapulina chapulina added the 🌱 garden Ignition Garden label May 17, 2022
@chapulina chapulina mentioned this pull request May 17, 2022
Merged
11 tasks
Base automatically changed from chapulina/3/ign_deprecations_4 to main May 24, 2022 16:26
@chapulina
merged from main
b836bbc 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 946a27a into main May 24, 2022
@chapulina chapulina deleted the chapulina/3/ign_deprecations_5 branch May 24, 2022 16:42
@chapulina chapulina mentioned this pull request Jun 17, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @scpeters