Skip to content

Commit

Permalink
Split up cases in test_check, better naming
Browse files Browse the repository at this point in the history
  • Loading branch information
emdoyle committed Feb 8, 2024
1 parent e696fac commit 3f8ca6a
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions tests/test_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def _test_check_import(
)


def test_check_import(boundary_trie):
def test_check_import_across_boundary_public(boundary_trie):
assert (
_test_check_import(
boundary_trie,
Expand All @@ -31,6 +31,9 @@ def test_check_import(boundary_trie):
)
is None
)


def test_check_import_within_boundary(boundary_trie):
assert (
_test_check_import(
boundary_trie,
Expand All @@ -39,6 +42,9 @@ def test_check_import(boundary_trie):
)
is None
)


def test_check_import_external_module(boundary_trie):
assert (
_test_check_import(
boundary_trie,
Expand All @@ -47,6 +53,9 @@ def test_check_import(boundary_trie):
)
is None
)


def test_check_import_across_boundary_private(boundary_trie):
assert (
_test_check_import(
boundary_trie,
Expand All @@ -55,17 +64,9 @@ def test_check_import(boundary_trie):
)
is not None
)
assert (
_test_check_import(
boundary_trie,
file_mod_path="domain_one",
import_mod_path="domain_three.anything",
)
is not None
)


def test_check():
def test_check_example_dir_end_to_end():
expected_errors = [
ErrorInfo(
import_mod_path="example.domain_one.interface.domain_one_interface",
Expand Down

0 comments on commit 3f8ca6a

Please sign in to comment.