Moving from layers to groups, round 2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fallback to layers
…d in, and remove console logging call
I've rewritten the initial event binding to use $('desc').parent()
instead of checking every element for a desc child. This should
improve performance, although I haven't benchmarked it.
I've also pulled the event bindings into a public function in lieu
of using $.delegate or $.on. This is not as nice as using one of
the jQuery deferred functions, but since there is not a CSS selector
equivalent of $('desc').parent(), and since there is no convenient
guaranteed-present parent element outside of document or svg
(neither of which is great to use performance-wise), and since
the use case of dynamic SVG elements currently seems to be rare,
I think this is a reasonable way of accomplishing the event binding
while still having the possibility of rebinding on element insertion.
Squashed commit of the following: commit cad63e8 Author: Emily Dirsh <[email protected]> Date: Thu Oct 16 13:15:49 2014 -0400 Rewrite MagicMockup to use no external dependencies Removed all external dependencies for MagicMockup. This change should improve performance. It reduces script size by a lot. It also improves the build process - making it much simpler and easier to maintain. * Rewrote MagicMockup in vanilla js * Added test.svg as a click through test file to ensure that current and future changes don't break MM commit 0a5356d Author: Emily Dirsh <[email protected]> Date: Fri Jun 6 15:00:09 2014 -0400 WIP - Begin removing jquery and other dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up and rewrote some of the code. Also changed the way the event bindings work - I explain that more in the commit message.