fix config validator for region in network client #956
Conversation
Added region argument while creating network client for terraform validations
|
|
gardener-robot
added
area/robustness
|
@snwzd Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @snwzd for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
Hi, This pull request is regarding the fix for the issue issue that I am facing, please review it and tell me if there are any other changes that need to be made. |
There was a problem hiding this comment.
@snwzd thank you for the contribution. Only a minor nit below
| networkingClient, err := clientFactory.Networking(func(opts gophercloud.EndpointOpts) gophercloud.EndpointOpts { | ||
| opts.Region = infra.Spec.Region | ||
| return opts | ||
| }) |
There was a problem hiding this comment.
We already should have a function to do just that, so can you give it a try with:
networkingClient, err := clientFactory.Networking(openstackclient.WithRegion(infra.Spec.Region))
There was a problem hiding this comment.
@snwzd you need to run make generate (according to the test results)
There was a problem hiding this comment.
I ran make generate, but it didn’t seem to make much changes. I think it removed the unused gophercloud import, which was the only noticeable change. (probably my editor missed it)
Updated region argument while creating network client for terraform validations
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
AndreasBurger
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Added region argument while creating network client for terraform validations
How to categorize this PR?
/area robustness
/kind bug
/platform openstack
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #955
Special notes for your reviewer:
While creating networking client for terraform validations, region is not being used as parameter for the function.