Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release v1.49] fix inventory for deleted resources #1062

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[Release v1.49] fix inventory for deleted resources #1062

merged 1 commit into from
Jan 15, 2025

Conversation

AndreasBurger
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1056

Special notes for your reviewer:
Cherry-pick of #1057

Release note:

Fix an issue causing nil pointer exception when the remote resource that was once existing and present in the inventory, had been deleted during reconciliation

@kon-angelo @AndreasBurger
fix inventory for deleted resources (#1057)
2fe7170 
* fix inventory for deleted resources

* improve logging messages

* improve logging messages v2
@AndreasBurger AndreasBurger requested review from a team as code owners January 15, 2025 14:20
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure labels Jan 15, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 15, 2025
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Jan 15, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2025
kon-angelo
kon-angelo approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 15, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 15, 2025
@AndreasBurger AndreasBurger merged commit b676fd8 into release-v1.49 Jan 15, 2025
21 checks passed
@AndreasBurger AndreasBurger deleted the hotfix-149 branch January 15, 2025 14:53
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreasBurger @kon-angelo @gardener-robot-ci-2 @gardener-robot