Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data store generic #83

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Make data store generic #83

merged 3 commits into from
Jan 17, 2025

Conversation

dimityrmirchev
Copy link
Member

What this PR does / why we need it:
This will help implement #31

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jan 7, 2025
@gardener-prow gardener-prow bot requested a review from vpnachev January 7, 2025 11:42
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 7, 2025
@dimityrmirchev
Copy link
Member Author

/kind enhancement

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 7, 2025
vpnachev
vpnachev approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 7, 2025

LGTM label has been added.

Git tree hash: 90b1e562633875b9f8f249c3060355cecb68743a

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@dimityrmirchev
Copy link
Member Author

/test pull-gardener-discovery-server-unit

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@gardener-prow gardener-prow bot requested a review from vpnachev January 8, 2025 07:43
@vpnachev
Copy link
Member

vpnachev commented Jan 8, 2025 

>>> The following actual dependencies are missing (need to be added):
internal/store
>>> The following dependencies are not needed actually (need to be removed):
>>> Run './hack/update-skaffold-deps.sh' to fix.

The code needs to be re-generated.

vpnachev
vpnachev approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 17, 2025

LGTM label has been added.

Git tree hash: 8ec3bbfa195fc4fa6594b9b3f579866f10bdf21f

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vpnachev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit 87076cc into gardener:main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees

@vpnachev vpnachev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimityrmirchev @vpnachev