Add helper function to parse signing algorithm according to rfc #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
size/xs
gardener-robot-ci-2
added
needs/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-signing-algorithm
branch
from
077898b to
a30c9e4
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Altough it is an option, it may not be beneficial to directly adjust the enum to mirror the standard described in the rfc because (1) existing cosign signatures would not be reused but instead new signatures would be appended because it seems the algorithm had changed (2) OCM cli expects algorithms to be upper case
8R0WNI3
force-pushed
the
8R0WNI3-signing-algorithm
branch
from
a30c9e4 to
a5bf89f
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Lakom expects signing algorithm to match the standard format described in https://datatracker.ietf.org/doc/html/rfc3447, hence adding a helper function to create the expected format.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Altough it is an option, it may not be beneficial to directly adjust the enum to mirror the standard described in the rfc because (1) existing cosign signatures would not be reused but instead new signatures would be appended because it seems the algorithm had changed (2) OCM cli expects algorithms to be upper case
Release note: