Skip to content

Commit

Permalink
Revert "Filter out version attribute from extra-id"
Browse files Browse the repository at this point in the history
This reverts commit 5686aad.

version implicitly added to extra-id due to ocm-cli bug.
avoid hacky filtering by making sure to consistently use
component-descriptor prior to ocm-cli instruction with side effects.
  • Loading branch information
zkdev committed Jan 7, 2025
1 parent d162224 commit c7f4b19
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions dso/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ def normalise_artefact_extra_id(
sorted by key in alphabetical order and concatinated following pattern:
key1:value1_key2:value2_ ...
'''
# steamline inconsistency between extra-id handling, drop version attribute entirely
if artefact_extra_id.get('version'):
del artefact_extra_id['version']

s = sorted(artefact_extra_id.items(), key=lambda items: items[0])
return '_'.join([':'.join(values) for values in s])

Expand Down

0 comments on commit c7f4b19

Please sign in to comment.