This repository has been archived by the owner on May 26, 2023. It is now read-only.
improves error message in cache #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
schrodit
suggested changes
Aug 26, 2021
| ErrNotFound = errors.New("not cached") | ||
|
|
||
| // ErrInvalidBlob is an error that indicates that a blob is invalid | ||
| ErrInvalidBlob = errors.New("invalid blob") |
There was a problem hiding this comment.
not sure if we need a dedicated error for this.
MAybe it would be more helpful to return the real error with fmt.Errorf("invalid blob: %w", err)
|
@jschicktanz You have pull request review with status CHANGES_REQUESTED, please check |
|
@enrico-kaack-comp You have pull request review open invite, please check |
|
The Gardener project currently lacks enough contributors to adequately respond to all issues and PRs.
/lifecycle stale |
|
@gardener-ci-robot Command |
gardener-robot
added
the
lifecycle/stale
gardener-robot
added
lifecycle/rotten
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
improves error message in the cache. the "not cached" msg was misleading, as the actual error was that the blob content didn't match with the descriptor data
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: