Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Dependencies.OtherPackagesLoadedInAdvance in PackageInfo.g #5776

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Deprecate Dependencies.OtherPackagesLoadedInAdvance in PackageInfo.g #5776

merged 1 commit into from
Aug 26, 2024

Conversation

ThomasBreuer
Copy link
Contributor

This feature is regarded as deprecated, see issue #5773.
Currently only the documentation gets changed, the implementation is kept as it is.

@ThomasBreuer
do not document OtherPackagesLoadedInAdvance
3c75e4b 
This feature is regarded as deprecated.
Currently only the documentation gets changed,
the implementation is kept as it is.
@ThomasBreuer ThomasBreuer added topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes kind: removal or deprecation A feature was removed or deprecated / made obsolete labels Aug 20, 2024
frankluebeck
frankluebeck approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@frankluebeck frankluebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a sensible simplification.

@ThomasBreuer ThomasBreuer merged commit 8936b67 into gap-system:master Aug 26, 2024
28 of 30 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_deprecate_OtherPackagesLoadedInAdvance branch August 26, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@frankluebeck frankluebeck frankluebeck approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
kind: removal or deprecation A feature was removed or deprecated / made obsolete release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasBreuer @fingolfin @frankluebeck