-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more fields when disclosing publisher or caller #101
Add more fields when disclosing publisher or caller #101
Conversation
This further improves the compatibility to crossbar.io by disclosing caller_authid, caller_authrole, caller_authmethod and caller_authextra if set.
Thank you for this. However, I must request that only The WAMP standardization group has reached the consensus that the supported fields will be Some background (from discussion): On the subject fo including these fields with publisher and caller identification, according to Tobias Oberstein (Crossbar.IO):
Also from Oberstein:
Related issue with autobahn-js: crossbario/autobahn-js#219 If we want to include additional fields, these should be optional to enable, default disabled, and the non-standard field names should begin with Conclusion: Nexus needs to include |
router/broker.go
Outdated
"authrole", | ||
"authid", | ||
"authmethod", | ||
"authextra", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only features needed are "authid" and "authrole". See PR discussion.
router/dealer.go
Outdated
"authrole", | ||
"authid", | ||
"authmethod", | ||
"authextra", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only features needed are "authid" and "authrole". See PR discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I am going to hold off merging for a day or two until I get some feedback from WAMP standards group on whether they want publisher_authid
or just authid
, and same for other fields.
This further improves the compatibility to crossbar.io by disclosing
caller_authid, caller_authrole, caller_authmethod and caller_authextra if set.
For pubsub, the same properties are exposed.