-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating chrome browser into Steam image to extend its usefulness #190
Open
TheRainstorm
wants to merge
2
commits into
games-on-whales:master
Choose a base branch
from
TheRainstorm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // -*- mode: jsonc -*- | ||
| { | ||
| "layer": "top", // Waybar at top layer | ||
| "position": "top", // Waybar position (top|bottom|left|right) | ||
| "height": 30, // Waybar height (to be removed for auto height) | ||
| // "width": 1280, // Waybar width | ||
| "spacing": 4, // Gaps between modules (4px) | ||
| // Choose the order of the modules | ||
| "modules-left": [ | ||
| "sway/workspaces", | ||
| "sway/mode", | ||
| "sway/scratchpad", | ||
| "custom/kitty", | ||
| "custom/steam", | ||
| "custom/chrome" | ||
| ], | ||
| "modules-center": [ | ||
| "sway/window" | ||
| ], | ||
| "modules-right": [ | ||
| "pulseaudio", | ||
| "network", | ||
| "cpu", | ||
| "memory", | ||
| "temperature", | ||
| "sway/language", | ||
| "clock" | ||
| ], | ||
| "custom/kitty": { | ||
| "format": "{} ", | ||
| "tooltip": false, | ||
| "on-click": "kitty" | ||
| }, | ||
| "custom/chrome": { | ||
| "format": "<u>google</u>", | ||
| "tooltip": false, | ||
| "on-click": "google-chrome-stable" | ||
| }, | ||
| "custom/steam": { | ||
| "format": "<u>steam</u>", | ||
| "tooltip": false, | ||
| "on-click": "/usr/games/steam" | ||
| }, | ||
| "sway/mode": { | ||
| "format": "<span style=\"italic\">{}</span>" | ||
| }, | ||
| "sway/scratchpad": { | ||
| "format": "{icon} {count}", | ||
| "show-empty": false, | ||
| "format-icons": ["", ""], | ||
| "tooltip": true, | ||
| "tooltip-format": "{app}: {title}" | ||
| }, | ||
| "idle_inhibitor": { | ||
| "format": "{icon}", | ||
| "format-icons": { | ||
| "activated": "", | ||
| "deactivated": "" | ||
| } | ||
| }, | ||
| "tray": { | ||
| // "icon-size": 21, | ||
| "spacing": 10 | ||
| }, | ||
| "clock": { | ||
| // "timezone": "America/New_York", | ||
| "tooltip-format": "<big>{:%Y %B}</big>\n<tt><small>{calendar}</small></tt>", | ||
| "format-alt": "{:%Y-%m-%d}" | ||
| }, | ||
| "cpu": { | ||
| "format": "{usage}% ", | ||
| "tooltip": false | ||
| }, | ||
| "memory": { | ||
| "format": "{}% " | ||
| }, | ||
| "temperature": { | ||
| // "thermal-zone": 2, | ||
| // "hwmon-path": "/sys/class/hwmon/hwmon2/temp1_input", | ||
| "critical-threshold": 80, | ||
| // "format-critical": "{temperatureC}°C {icon}", | ||
| "format": "{temperatureC}°C", | ||
| "format-icons": ["", "", ""] | ||
| }, | ||
| "network": { | ||
| // "interface": "wlp2*", // (Optional) To force the use of this interface | ||
| "format-wifi": "{essid} ({signalStrength}%) ", | ||
| "format-ethernet": "{ipaddr}/{cidr}", | ||
| "tooltip-format": "{ifname} via {gwaddr}", | ||
| "format-linked": "{ifname} (No IP)", | ||
| "format-disconnected": "Disconnected ⚠", | ||
| "format-alt": "{ifname}: {ipaddr}/{cidr}" | ||
| }, | ||
| "pulseaudio": { | ||
| // "scroll-step": 1, // %, can be a float | ||
| "format": "{volume}% {icon} {format_source}", | ||
| "format-bluetooth": "{volume}% {icon} {format_source}", | ||
| "format-bluetooth-muted": " {icon} {format_source}", | ||
| "format-muted": " {format_source}", | ||
| "format-source": "{volume}% ", | ||
| "format-source-muted": "", | ||
| "format-icons": { | ||
| "headphone": "", | ||
| "hands-free": "", | ||
| "headset": "", | ||
| "phone": "", | ||
| "portable": "", | ||
| "car": "", | ||
| "default": ["", "", ""] | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't do this, you can already open up a root shell using Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to mention this change. Initially, this pull request was mostly intended for my personal use. Since when I connect in full screen via Moonlight, I prefer to operate within the terminal inside Moonlight. Therefore, to make things easier for myself, I set a root password so I could switch to the root user.
If, in the future, there's support for keeping the container after closing an app, then the need to install applications inside the container will become more common. In that case, perhaps granting sudo privileges to the retro user would be more appropriate? (I noticed that the retro user is created in the 10-setup_user.sh script of the base image, without sudo privileges.)