Allow to keep quota's default value #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the current implementation it was impossible to update a quota and to keep the default state (no/registered/unregistered) of a quota as it is. was documented correctly but likely undesired .. for instance it seemed impossible to just change the value of an existing quota.
bernt-matthias
force-pushed
the
fix/quota-allow-to-keep-default
branch
2 times, most recently
from
803c26f
to
1847500
Compare
bernt-matthias
commented
Aug 22, 2023
to keep default state of the quota as it is
|
I think this has been superseded by #489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the current implementation, it was impossible to update a quota and to leave the
default = "no".was documented correctly but likely undesired .. for instance, it seemed impossible to just change the value of an existing non-default quota.
Edit: you can see it failing over here #479. I cherry-picked the test to this PR
TODO: change the default of the default parameter?