Add LabelLinksIndicator to LabelDelivery for ShipmentServiceOption #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
requested changes
Oct 8, 2021
| @@ -155,6 +170,24 @@ public function setLabelLinkIndicator($labelLinkIndicator) | |||
| return $this; | |||
| } | |||
|
|
|||
| /** | |||
| * @return string | |||
There was a problem hiding this comment.
Suggested change
| * @return string | |
| * @return boolean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
At work, we realized what could be a small error. For ShipmentServiceOptions, the node expects a LabelLinksIndicator instead of the LabelLinkIndicator (note the 's'), in contrast with the LabelRecoveryRequest which indeed expects the LabelLinkIndicator, without the 's'.
The result was that the URL was not returned in the accept response.
To fix that, we added an option to set LabelLinksIndicator modifying as well the relevant
ifstatement for ShipmentServiceOptions.Again, let me know if I need to do something else in order to have it merged.
Cheers!
X.