Prevent a Hash change triggered scroll from triggering hash recalculation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoroldao
changed the title
… triggering hash recalculation
|
I don't think this has been updated in the npm module. The module states that the files are up to date but this forced scroll change does not exist in the code and the hash recalculation is still occurring. Also the code in Manager.js, ScrollableAnchor.js, and index.js are wildly different to the code in the git repo |
|
I'm not sure I follow. |
|
What is the problem with merging this? It fixes a pretty critical bug, in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23