Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update examples in implementation documentation #535

Merged
merged 4 commits into from
Aug 28, 2024
Merged

docs: update examples in implementation documentation #535

merged 4 commits into from
Aug 28, 2024

Conversation

korikuzma
Copy link
Contributor

close #531

  • resolve typos + only use one space after period

@korikuzma
docs: update examples in implementation documentation
87458ca 
close #531

* resolve typos + only use one space after period
@korikuzma korikuzma added the Docs label Aug 27, 2024
@korikuzma korikuzma self-assigned this Aug 27, 2024
ahwagner
ahwagner approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One spot that could use a little additional work mentioned, after which this can be merged.

docs/source/conventions/computed_identifiers.rst Show resolved Hide resolved
docs/source/conventions/example.rst Show resolved Hide resolved
docs/source/conventions/example.rst Outdated Show resolved Hide resolved
@korikuzma
Copy link
Contributor Author

@ahwagner Applied suggestions in last commit (075f8fa). Let me know if this is what you were thinking.

@korikuzma
update styling for attributes
577aa66 
follow docs/source/style.rst conventions
@korikuzma
Copy link
Contributor Author

@ahwagner I also updated the styling for attributes (following this https://vrs.ga4gh.org/en/2.0.0-ballot.2024-08/style.html#text-styles). I'm reading through the docs and it seems to be inconsistent for attributes. Should I update the styling in a new PR?

@ahwagner
Copy link
Member

@ahwagner I also updated the styling for attributes (following this https://vrs.ga4gh.org/en/2.0.0-ballot.2024-08/style.html#text-styles). I'm reading through the docs and it seems to be inconsistent for attributes. Should I update the styling in a new PR?

Yes, that would be great, thanks!

@korikuzma korikuzma mentioned this pull request Aug 28, 2024
Closed
@ahwagner ahwagner merged commit c649e3b into 2.x Aug 28, 2024
3 checks passed
@ahwagner ahwagner deleted the issue-531 branch August 28, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner approved these changes

@larrybabb larrybabb Awaiting requested review from larrybabb larrybabb is a code owner

Assignees

@korikuzma korikuzma

Labels
Docs
Projects
VRS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update examples in implementation documentation
2 participants
@korikuzma @ahwagner