Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]modify avatar editor #41

Closed

Conversation

kaizumaki
Copy link
Collaborator

@kaizumaki kaizumaki commented Jul 29, 2021

close #21

I get a CORS error when opening the avatar edit window. (And it is sometimes error free.)
I think the cause of this is in the CORS header setting in amplify. What do you think?

スクリーンショット 2021-07-29 21 49 01

@loleg
Copy link

loleg commented Feb 26, 2022

Just two add a small thought here: it looks like your code changes update the editor, but not directly address the CORS problem - right? CORS errors are usually an issue with the server configuration - in this case, the S3 site hosting your image does not like to get requests from localhost. You might want to test this again on a remote server with a real domain name, like a stage server. And if I am correct, then provide instructions for developers about a workaround - like using another S3 provider or some other storage mechanism in testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to use react-avatar-editor for uploading avatar
3 participants