build: provide rime.pdb when MSVC build #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(script_translator): correction can cause segfault
When finding the candidates for the last page,
ScriptTranslation::PrepareCandidate can return nullptr, leading
to segfault.
++correction_count_ > max_corrections_
it is the correct logic to discard more correction candidates after the top N;
if inverted, all correction candidates except the top N are displayed.
correctly update member variables for the no more candidates to display case.
---------
Co-authored-by: 居戎氏 <[email protected]>
Fixes rime#866 Closes rime#640 Squashed commit of the following: commit e3addcf Author: groverlynn <[email protected]> Date: Tue Mar 28 01:07:39 2023 +0200 Skip switches with no state labels --------- Co-authored-by: 居戎氏 <[email protected]>
sel_start, sel_end need to be adjusted if the inserted caret is before the selected range. Closes rime#860
clamp new_index between 0 and candidate_count - 1 --------- Co-authored-by: 居戎氏 <[email protected]>
API type: RimeApi_stdbool API entry function: rime_get_api_stdbool
Signed-off-by: shewer <[email protected]>
提供 librime-lua 取得 options, propreties 中的狀態
…#900) Previously, the two APIs will always delete the currently selected candidate, regardless of what its argument is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info