Only use local crt0 and lds files #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One other thing - by using crt0 and lds locally do we even need the 3.0.18 dependency anymore? |
|
I also think we can drop the bump. |
At least as of gnu-efi 3.0.18 these still don't have support for SBAT or SBOM. Keep using the CRT0 and LDS distributed with fwupd-efi for now. If/when these can be switched to system ones fwupd-efi will bump a dependency on that version of gnu-efi and drop the local copies. Fixes: #56
superm1
force-pushed
the
local-crt0-only
branch
from
39b1551 to
4630aad
Compare
|
Options:
This is why this only affects ARM64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBAT and SBOM support aren't in upstream gnu-efi. If some day everything is upstream, we can bump our version dep to a newer version and only pull the upstream ones.
CC @gmbr3
CC @vathpela