Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to use cc as ld (Since meson doesn't support calling LD) #50

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

dataCobra
Copy link
Contributor

@dataCobra dataCobra commented Feb 15, 2024

With the help of another maintainer of Void @leahneukirchen we tried to understand the cross compilation issues.

We figured out that meson doesn't support calling LD. Because of that we changed the behavior and now CC will be used for LD. Now building and installing works without the variables efi_cc and efi_ld which got removed prior to version 1.4.

I didn't got the chance to try fwupd-efi fully with this changes. If you have some input about what could be some good tests please let me know. None of my systems have a update at the moment to test this.

This does fix #39.

@hughsie hughsie requested a review from superm1 February 15, 2024 15:14
@superm1
Copy link
Member

superm1 commented Feb 15, 2024

You can use fwupdmgr reinstall to try to trigger a reinstall event for your current firmware. This looks good though to me.

@dataCobra
Copy link
Contributor Author

Tested with fwupdmgr reinstall and it worked like a charm.

@superm1 superm1 merged commit e4a4611 into fwupd:main Feb 15, 2024
5 checks passed
@superm1
Copy link
Member

superm1 commented Feb 15, 2024

Thanks!

@dataCobra dataCobra deleted the cc-to-ld branch September 28, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1.4+ build scripts assume chosen linker can be called by executable matching its ID
2 participants