Skip to content

Commit

Permalink
fixup! fixup! fixup! Update epochs when changing key and cipher state…
Browse files Browse the repository at this point in the history
… for dtls 1.3
  • Loading branch information
fwh-dc committed Jun 11, 2024
1 parent c7cf044 commit 52202a4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
13 changes: 5 additions & 8 deletions doc/designs/dtlsv1_3/dtlsv1_3-main.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ This is enforced by the macro `SSL_CONNECTION_MIDDLEBOX_IS_ENABLED(sc)`.
The DTLSv1.3 implementation uses the label "dtls1.3" as described by RFC9147
section 5.9.

#### DTLS 1.3 Epoch

The DTLSv1.3 implementation modifies the epoch according to RFC9147 section 6.1
for DTLSv1.3 connections.

Implementation progress
-----------------------

Expand All @@ -83,7 +88,6 @@ is not covered by these workitems and must be implemented separately.
| ACK messages | - |
| Use HelloRetryRequest instead of HelloVerifyRequest | #22985, #22400 |
| Message transcript | - |
| DTLSv1.3 epoch | #23553 |
| ClientHello | #23320 |
| EndOfEarlyData message | - |
| Variable length header | - |
Expand Down Expand Up @@ -129,13 +133,6 @@ And

> 4.2.3. Record Number Encryption
#### DTLSv1.3 epoch

The epoch is maintained differently from DTLS 1.2

> The DTLS epoch ... is set as the least significant 2 octets of the connection
> epoch, which is an 8 octet counter incremented on every KeyUpdate
#### ClientHello

DTLS adds legacy_cookie which has a forced value. And there are changes to the
Expand Down
4 changes: 2 additions & 2 deletions test/recipes/70-test_dtls13epoch.t
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use TLSProxy::Message;
my $test_name = "test_dtlsrecords";
setup($test_name);

plan skip_all => "TLSProxy isn't usable on $^O"
if $^O =~ /^(VMS)$/;
plan skip_all => "DTLSProxy isn't usable on $^O"
if ($^O =~ /^(VMS)$/) || ($^O =~ /^(MSWin32)$/);

plan skip_all => "$test_name needs the dynamic engine feature enabled"
if disabled("engine") || disabled("dynamic-engine");
Expand Down

0 comments on commit 52202a4

Please sign in to comment.