Add .desktop entry for XSession #876
Conversation
There was a problem hiding this comment.
Hi @Zirias
Thanks for looking at this. Overall looks OK to me, but I do have some comments in-line for your consideration.
Oh, and the fvwm3.desktop.in file will need adding to EXTRA_DIST.
Thanks!
|
Verified the "fixed" .desktop file works well with sddm, just assuming other display managers have no issues either .... |
|
Hi @Zirias Looking good, thank you! I didn't mean to suggest that we needed a separate Makefile.am file under contrib/ rather, we can just add this change directly to |
|
Ahh, I assumed this would "pollute" the toplevel Makefile, but if you prefer it that way, just a second, will make the change even smaller :-) |
Add a (minimal) .desktop file of type XSession, so fvwm3 is discoverable for display managers following freedesktop.org standards. Fixes fvwmorg#12
|
Hi @Zirias Brilliant -- this is looking good. Will merge later on today, once I've finished work. |
Add a (minimal) .desktop file of type XSession, so fvwm3 is discoverable for display managers following freedesktop.org standards.
Fixes #12
It adds a truly minimal XSession
.desktopfile for FVWM3, installed in$(xsessionsdir)which defaults to$(datarootdir)/xsessions.Edit, in case you wonder about the custom make recipe, I just didn't find a better way. When you try to subsitute
@bindir@from autoconf, it expands to${exec_prefix}/bin(literal), so this isn't usable in a .desktop file ....