Skip to content

Commit

Permalink
Fixed a saving bug
Browse files Browse the repository at this point in the history
  • Loading branch information
fuzhanrahmanian committed Dec 11, 2023
1 parent 2ef9db4 commit 4036aa4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
7 changes: 7 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
History
=======

1.2.1 (2023-12-11)
-------------------
* Added Ciclic Voltammetry to the functions
* CA, CP and CV can be used with multiple plots to chose from
* New and Imrpoved GUI
* Fixed saving bug

1.1.0 (2023-08-07)
-------------------
* Fixes issue with mismatch array length when positive imaginary data is given
Expand Down
2 changes: 1 addition & 1 deletion madap/echem/voltammetry/voltammetry_CA.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def save_data(self, save_dir:str, optional_name:str = None):
"""
log.info("Saving data...")
# Create a directory for the data
name, save_dir = self._assemble_name(save_dir, optional_name, self.__class__.__name__)
save_dir, name = self._assemble_name(save_dir, optional_name, self.__class__.__name__)
if self.reaction_order == 1:
reaction_rate_constant_unit = "1/s"
elif self.reaction_order == 2:
Expand Down
2 changes: 1 addition & 1 deletion madap/echem/voltammetry/voltammetry_CP.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def save_data(self, save_dir:str, optional_name:str = None):
"""
log.info("Saving data...")
# Create a directory for the data
name, save_dir = self._assemble_name(save_dir, optional_name, self.__class__.__name__)
save_dir, name = self._assemble_name(save_dir, optional_name, self.__class__.__name__)
# add the settings and processed data to the dictionary
added_data = {
"Applied Current [A]": self.applied_current,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,6 @@
test_suite='tests',
tests_require=test_requirements,
url='https://github.com/fuzhanrahmanian/MADAP',
version='1.1.0',
version='1.2.1',
zip_safe=False,
)

0 comments on commit 4036aa4

Please sign in to comment.