FR-14304 - Trigger Oauth pipeline after publish #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemzif1
requested review from
aviadmizrachi,
frontegg-david,
amirjaron,
MaxArnautFrontegg,
ihigani,
TomerFrontegg,
mariavlasov,
yuvalotem1,
isra-frontegg,
AtaliaRefua and
doregg
as code owners
rotemzif1
force-pushed
the
FR-14304-trigger-oauth
branch
from
fff6a97 to
76486b5
Compare
doregg
reviewed
Nov 26, 2023
| } | ||
|
|
||
| if (!allPackagesIndexed) { | ||
| timeout--; |
There was a problem hiding this comment.
I think we can improve the timeout logic. I think we can define how many time to run it regardless of the timeout var
doregg
reviewed
Nov 26, 2023
| @@ -99,6 +99,34 @@ jobs: | |||
| env: | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }} | |||
| - name : Wait until NPM registry finished indexing the new version | |||
There was a problem hiding this comment.
I think it should be part of the consumer / run it in parallel with the next pipeline steps - it shouldn't be a blocker.. (unless it's very fast)
There was a problem hiding this comment.
Its a great idea, if we go with this direction I suggest we think together how to do it and provide it also in admin box, this is the same logic when we publish and then do something that is holding up until the version is live
There was a problem hiding this comment.
can u add a ticket? in the pipeline effort epic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new workflow for triggering oauth service pipeline of opening a PR that updating frontegg, on our publish flow. (Oauth workflow - https://github.com/frontegg/oauth-service/actions/workflows/update-react-dependency.yaml)
This PR includes 4 files:
This PR will be pushed the same way to trigger dashboard service as well.