update permission section #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add permissions for library module remove permissions in the example
alex-minaiev-frontegg
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can add these permissions to the library module manifest file. So, we don't need to add them to the manifest of the application that we are integrating the library into.
Because when we build our application, all the manifests are merged into one, so we will have one file with all the permissions.
This will make library integration a little bit easier.
Another question about the permissions - POST_NOTIFICATIONS and ACCESS_NETWORK_STATE - do we really need them? Or if they are optional and not needed in all cases, then it is better to leave these two permissions in the integration guide and add a description of why each of them is worth adding.