-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/adding custom label and dimensions names #4
base: main
Are you sure you want to change the base?
Feat/adding custom label and dimensions names #4
Conversation
We need it for all the charts which has X and Y Axis. |
Refer to recharts documentation https://recharts.org/en-US/api/YAxis#label |
Okay got it ! |
added names functionality in all the charts with x and y axis |
Can you explain why you have decided to use Tooltip for Axis labels? Axis labels can be defined inside the axis tags themselves: https://recharts.org/en-US/api/YAxis#label |
@arihantparsoya I added the names using the ToolTip component so that It will be more interactive for users as well as a Cleaner UI will be maintained when there will be a large set of data, but as you want this to be in Axis itself, I will work on it! |
Yes, the the axis is the main thing, user should be able to know the axis without using the tooltips. Can you share a screenshot of the tooltip after your modified code? I would suggest keep the tooltip changes in separate branch and focus only on the axis for not. because tooltip is defined in other locations as well. |
labelNames
anddimensionsNames
in the interfaceChartInterface
Tooltip
for viewing the custom Label & Dimension Names.storybook