Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hawken/avoid caching menu errors #719

Closed
wants to merge 11 commits into from

Conversation

hawkrives
Copy link
Member

  • add dep on p-memoize
  • use p-memoize to cache the bonapp requests - p-memoize doesn't cache rejected promises
  • add central one-{minute,hour,day} caches
  • p-memoize carleton/calendar
  • p-memoize carleton/contacts
  • p-memoize carleton/convos
  • p-memoize carleton/dictionary
  • p-memoize carleton/menu
  • p-memoize stolaf/hours
  • p-memoize stolaf/transit
  • fix menu caching again (from refactor)

@hawkrives
Copy link
Member Author

Turns out this approach doesn't work. The memorize gets called with no arguments, so it returns the same data for any subsequent call. For any URL.

@hawkrives hawkrives closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants