Armbe8 patches #1130
Open
Armbe8 patches #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2025 10:33
To build helpers use:
OBJCOPY=armeb-linux-gnueabi-objcopy MESON=/root/frida/subprojects/frida-core/releng/meson/meson.py BUILDDIR=/root/frida/subprojects/frida-core/build FRIDA_HOST=linux-armbe8 make -C subprojects/frida-core/src/linux/helpers
oleavr
requested changes
Jan 9, 2025
| @@ -1988,7 +1988,11 @@ namespace Frida { | |||
| #elif ARM | |||
| target_address &= ~1; | |||
|
|
|||
| # if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ | |||
There was a problem hiding this comment.
Does the Vala compiler define this?
There was a problem hiding this comment.
Yeah. It seems to work just fine. Without the change it dies.
src/linux/helpers/loader.c
Outdated
| ssize_t n; | ||
|
|
||
| /* avoid inline initialization to prevent the compiler attempting to insert a call to memset */ |
There was a problem hiding this comment.
Comments should start with the first word capitalized and end in a full stop.
src/linux/helpers/loader.c
Outdated
| }; | ||
| struct msghdr msg; | ||
|
|
||
| /* avoid inline initialization to prevent the compiler attempting to insert a call to memset */ |
There was a problem hiding this comment.
Comments should start with the first word capitalized and end in a full stop.
added 2 commits
January 9, 2025 17:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to support ARMBE8