Fw 2.9.0 migration #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
|
|
||
| RUN pip show elastalert2 | ||
|
|
||
| RUN echo "coming here..." |
There was a problem hiding this comment.
can we remove this print statement?
Dockerfile
Outdated
| RUN echo "coming here..." | ||
| RUN ls /usr/local/lib/ | ||
| RUN ls /usr/lib/ | ||
| RUN ls /lib/ |
There was a problem hiding this comment.
these ls statement are required ?
commands.sh
Outdated
| @@ -0,0 +1,5 @@ | |||
| #!/bin/bash | |||
| echo "creating elastalert indices" | |||
| python -m elastalert.create_index --config /data/elastalert/config.yaml --verbose | |||
There was a problem hiding this comment.
--verbose should be removed from elastalert-create-index ?
verbose argument is not supported in old elastalert and throws an error. Is it working for new elastalert
RashmiRam
requested changes
Mar 28, 2023
| @@ -32,30 +32,30 @@ | |||
| packages=find_packages(exclude=["tests"]), | |||
| package_data={'elastalert': ['schema.yaml', 'es_mappings/**/*.json']}, | |||
| install_requires=[ | |||
| 'apscheduler>=3.9.1.post1,<4.0', | |||
| 'apscheduler>=3.8.1.post1,<4.0', | |||
There was a problem hiding this comment.
why other dependencies are downgraded?
There was a problem hiding this comment.
Python dependency issues were coming. these versions are what worked perfectly without issues.
| self.thread_data.total_hits = int(res['hits']['total']['value']) | ||
| try: | ||
| #using backwards compatibile msearch | ||
| res = self.thread_data.current_es.msearch(body=request) |
There was a problem hiding this comment.
If we are removing scroll, how else we are querying again and again?
There was a problem hiding this comment.
yes. this is the first changes made on top of elastalert 0.1.35 - commit
There was a problem hiding this comment.
No. that was for exclusively error rate. Isn't it?
elastalert error for default operator
[HAYS-4738] fix response and query for percentile query
* updated changes * added except block in get_new_terms * new-terms - composite field support added * updated test-cases for new-term * new-terms - made default size 500 * new-terms - updates test cases * new-term - set limit for terms_size * refresh interval - test cases added & other test case fixes * added missing except block & increase request_timeout in get_all_terms * bug fix - to avoid crash if new term initializaton fails * making use_keyword_postfix False by default * test cases fixed * added testcase for upper and lower bounds * moved get_msearch_query to utils * unnecessary lines removal * revert initialization exception bypass
[HAYS-4782]query_delay support in conf added
* changing percentage match query * changing percentage match query in test cases * changing dependency * adding size param for percentagMatch rule to get num_hits
* New Term Optimisation - Threshold Feature enabled, removed use of refresh interval, Sliding Terms Window * Test case updates --------- Co-authored-by: RashmiRam <[email protected]>
[HAYS-5029] include using use_count_query
add alert_time as label in alert
…pport, update docker file (#31) * changing alert data to stingified dict * checking query_key exist condition before adding * changing condition to json_paylaod key * removing extra fucntion * removing log file * removing print statement * chaging count addition condition * adding adv query support and changign count value of freq * adding advance query rule * removing print statements * adding missed count print statements * changing condition check * adding changes to support for OS * sticking to old version of image * syntax change * making all key values as strings * hardcoding python base image as well * reverting the change * changing package version * removing update * installing fixed versions * installing fixed versions * removing distroless * changign docker file
* Adding local datastore setup files * Added header X-Env to router requests if configured * Added header X-Env to router requests if configured * Changed X_ENV env variable name to X-ENV * Revert "Changed X_ENV env variable name to X-ENV" This reverts commit be627e7.
* changing es package version * changing elastalert to work for OS clusters
fix timestamp issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.