[FS-172266, FS-199069] : Conductor Monitor Changes for queue depth metrics #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab48917
reviewed
Aug 29, 2024
server/src/main/java/com/netflix/conductor/config/PrometheusIntegrationConfig.java
Outdated
Show resolved
Hide resolved
prabhakaranE6157
changed the base branch from
freshservice_staging
to
lt_test_load_gowtham
keerthivaasan-kanagaraj
changed the title
keerthivaasan-kanagaraj
changed the base branch from
lt_test_load_gowtham
to
freshservice_staging
geethalladi
reviewed
Oct 29, 2024
core/src/main/java/com/netflix/conductor/core/reconciliation/WorkflowSweeper.java
Show resolved
Hide resolved
geethalladi
reviewed
Oct 29, 2024
| taskDef -> { | ||
| } | ||
|
|
||
| // Commented out as we don't have use case for Pending Workflows as of now and hence we don't have pending workflow implementation from |
There was a problem hiding this comment.
- Remove these code if they are no longer needed
- We can always get them from the version control
geethalladi
reviewed
Oct 29, 2024
server/src/main/java/com/netflix/conductor/config/PrometheusIntegrationConfig.java
Outdated
Show resolved
Hide resolved
prabhakaranE6157
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered