Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passkey: enabled benchmark #2205

Merged
merged 3 commits into from
Oct 30, 2024
Merged

passkey: enabled benchmark #2205

merged 3 commits into from
Oct 30, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Oct 29, 2024

Goal

The goal of this PR is to enable benchmark side of the passkey pallet

Related to #2197

Checklist

  • Spec version incremented?

@aramikm aramikm requested a review from wilwade as a code owner October 29, 2024 19:36
@aramikm aramikm requested review from shannonwells, wilwade and enddynayn and removed request for wilwade October 29, 2024 19:36
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 29, 2024
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

// Measured: `168`
// Estimated: `4088`
// Minimum execution time: 2_182_480_000 picoseconds.
Weight::from_parts(2_190_791_000, 4088)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased a fair amount!

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have been cheaper 🚢

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 29, 2024
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@aramikm aramikm merged commit 00f81a9 into main Oct 30, 2024
29 checks passed
@aramikm aramikm deleted the uncomment_passkey_benchmarks branch October 30, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants