Fix Missing runtime APIs for Metadata v15 #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Oct 29, 2024
js/api-augment/types.d.ts
Outdated
Comment on lines
1
to
2
| // Unknown is causing these to be left out of the generated types. | ||
| // Adding them here for now. |
There was a problem hiding this comment.
I believe this is a type generation issue. I see a few other places that have to do this. As these are all simple, for now, I think it is best to add them here and move on.
There was a problem hiding this comment.
Hmm, they implemented TypeInfo macro . This is weird!
wilwade
commented
Oct 29, 2024
| @@ -1294,6 +1309,348 @@ cumulus_pallet_parachain_system::register_validate_block! { | |||
| BlockExecutor = cumulus_pallet_aura_ext::BlockExecutor::<Runtime, Executive>, | |||
| } | |||
|
|
|||
| // The implementation has to be here due to the linking in the macro. | |||
| // It CANNOT be extracted into a separate file | |||
| sp_api::impl_runtime_apis! { | |||
There was a problem hiding this comment.
These are just copied back from the runtime/frequency/src/apis.rs file. No additional changes.
wilwade
requested review from
a team,
shannonwells,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
the
metadata-changed
github-actions
bot
removed
the
metadata-changed
enddynayn
reviewed
Oct 29, 2024
|
|
||
| #[test] | ||
| fn runtime_apis_are_populated() { | ||
| assert!(RUNTIME_API_VERSIONS.len() > 0); |
aramikm
approved these changes
Oct 29, 2024
js/api-augment/types.d.ts
Outdated
Comment on lines
1
to
2
| // Unknown is causing these to be left out of the generated types. | ||
| // Adding them here for now. |
There was a problem hiding this comment.
Hmm, they implemented TypeInfo macro . This is weird!
github-actions
bot
added
the
metadata-changed
JoeCap08055
reviewed
Oct 30, 2024
github-actions
bot
removed
the
metadata-changed
wilwade
commented
Oct 30, 2024
| @@ -28,19 +28,8 @@ export default { | |||
| event: 'u8', | |||
| data: 'Vec<u8>', | |||
| }, | |||
| }, | |||
| runtime: { | |||
There was a problem hiding this comment.
Runtime types are part of the generation now
github-actions
bot
added
the
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
JoeCap08055
approved these changes
Oct 30, 2024
shannonwells
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to make sure that Metadata v15 has the correct Runtime API call data
Closes #2202
Discussion
Why? I cannot be 100% sure. See the linked issues in #2202 for more details.
From what I can tell, the way rust macros work with context means that this macro is stuck being in the same file as the const that uses it is
pub const VERSIONSpecifics
e2e/capacity/capacity_rpc.test.ts. Issue noted in code commentTesting
make start&&subxt metadata --version 15 -f json | jq .[1].V15.apis(Before this result would have been empty, now you have the runtime data!)