E2E tests: split transactions test and use more before all instead of beforeEach #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
requested review from
a team,
shannonwells,
mattheworris,
enddynayn,
aramikm,
claireolmstead and
JoeCap08055
and removed request for
a team
wilwade
commented
Oct 20, 2024
| const providerId = await createMsaAndProvider(fundingSource, stakingKeys, 'stakingKeys', 10n * CENTS); | ||
| const stakingAmount = 1n * DOLLARS; | ||
| const providerId = await createMsaAndProvider(fundingSource, stakingKeys, 'stakingKeys', 1n * DOLLARS); | ||
| const stakingAmount = 2n * DOLLARS; |
There was a problem hiding this comment.
These amounts needed to be higher for the variance in the weights
wilwade
commented
Oct 20, 2024
| // Stake the amount for each test | ||
| await assert.doesNotReject( | ||
| stakeToProvider(fundingSource, fundingSource, capacityProvider, numberOfTests * amountStaked) | ||
| ); |
There was a problem hiding this comment.
Instead of staking enough for each call, we instead just stake in the before based on how many tests there are
wilwade
commented
Oct 20, 2024
| @@ -757,113 +761,4 @@ describe('Capacity Transactions', function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('pay_with_capacity_batch_all', function () { | |||
There was a problem hiding this comment.
Moved to transactionsBatch.test.ts
wilwade
commented
Oct 20, 2024
| @@ -0,0 +1,132 @@ | |||
| import '@frequency-chain/api-augment'; | |||
wilwade
commented
Oct 20, 2024
| @@ -13,6 +13,7 @@ export const fundingSources = [ | |||
| 'capacity-rpcs', | |||
| 'capacity-staking', | |||
| 'capacity-transactions', | |||
| 'capacity-transactions-batch', | |||
There was a problem hiding this comment.
Each test must have a unique funding key
saraswatpuneet
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to clean up some some small things about the e2e tests
Part of #2154
Discussion
beforeEachactions to thebeforeallTesting
make e2e-tests