Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Detter documentation for Handles Pallet #2187

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Oct 17, 2024

Goal

The goal of this PR is to make it easier to understand the normalization and validation for handles

@wilwade wilwade requested review from jeanettedepatie, a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team October 17, 2024 15:15
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

Copy link
Collaborator

@jeanettedepatie jeanettedepatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific suggestions offered. But okay as is.

Due to the handling of homoglyphs, some handles will resolve to the same value.
For example, while the display may have diacriticals or homoglyphs, the handle is stored with diacriticals and homoglyphs normalized.
So `Zoë.35` and `Zoe.35` will both resolve to the same MSA Id.
TO allow multiple users to select the same handle, a distinguishing unique suffix is appended to to form the Display Handle.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TO allow multiple users to select the same handle, a distinguishing unique suffix is appended to to form the Display Handle.
A unique numeric suffix is appended to the base handle to form the display handle, allowing multiple users to select the same base handle.

@wilwade wilwade enabled auto-merge (squash) October 18, 2024 19:17
@wilwade wilwade merged commit d22ccc9 into main Oct 18, 2024
25 checks passed
@wilwade wilwade deleted the docs/handles-validation-normalization branch October 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants