Disable report_invalid in the vendor'd transaction pool
#2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
reviewed
Oct 14, 2024
| @@ -508,8 +508,12 @@ impl<Hash: hash::Hash + Member, Ex> BestIterator<Hash, Ex> { | |||
| impl<Hash: hash::Hash + Member, Ex> sc_transaction_pool_api::ReadyTransactions | |||
| for BestIterator<Hash, Ex> | |||
| { | |||
| fn report_invalid(&mut self, tx: &Self::Item) { | |||
| BestIterator::report_invalid(self, tx) | |||
| fn report_invalid(&mut self, _tx: &Self::Item) { | |||
There was a problem hiding this comment.
I'm worried about side effects. Maybe we can do some tests using https://github.com/paritytech/polkadot-stps?tab=readme-ov-file?
There was a problem hiding this comment.
Our e2e tests on testnet get close to that (and they were showing the issue) I think we could setup something like that as well for it.
wilwade
force-pushed
the
fix/hack-transaction-pool
branch
from
086b63d
to
0adb7c4
Compare
wilwade
force-pushed
the
fix/custom-transaction-pool
branch
from
ff9808d
to
1506df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to separate into a separate PR the only change happening to the vender'd transaction pool